TDT-2790 Clarify event visibility default is Google-only#333
Conversation
The EventVisibility KDoc described DEFAULT/PUBLIC/PRIVATE without noting that Microsoft and EWS accounts reject DEFAULT with a 400 error. Only Google events support DEFAULT. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=========================================
Coverage 83.73% 83.73%
Complexity 486 486
=========================================
Files 44 44
Lines 1359 1359
Branches 115 115
=========================================
Hits 1138 1138
Misses 149 149
Partials 72 72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AaronDDM
left a comment
AaronDDM
left a comment
There was a problem hiding this comment.
Good afternoon! Thanks for tightening this up — the note is accurate and the provider-specific 400 behaviour is worth calling out. One thing before this ships: there's no entry under the Unreleased section in CHANGELOG.md. Please add a short line under Changed (e.g. "Clarify that event default visibility is Google-only") so the doc fix is tracked. Docs themselves look good.
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
3 participants
What
Updates the KDoc for
EventVisibilityinsrc/main/kotlin/com/nylas/models/EventVisibility.ktto note thatDEFAULTonly works for Google events. Microsoft and EWS accounts return a 400 error whenDEFAULTis sent, but the enum docs didn't warn about this.Jira: TDT-2790 (sub-task of TDT-2765)
🤖 Generated with Claude Code